Commit hash | 3750281be1950df3da62f88c541e832d8306936f |
---|---|
Commit time | 2022-09-08 |
Committer | GitHub <noreply at github.com> |
Author time | 2022-09-08 |
Author | Andreas Freund <a.freundhaskel at gmail.com> |
Add EIP-4910: Royalty Bearing NFTs (#4910) * Initial Commit of Onchain Royalty Bearing NFT standard * Update to initial commit to address editor comments * Resolving figure reendering issue * Update EIPS/eip-4910.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Requested changes as per @lightclient requests from 3-22-2022 - Removed dependency on EIP-2771 - Added file with link to reference implementation since I could not add the entire reference implementation repo as a folder under assets/eip-4910 * adding reference implementation folder * Updates in response to requests by @SamWilsn - Removed all external links - Added Licensing to the header of the solidity contracts - Split Specifications and Rationales into separate section to align with EIP-1 - Intended the sections properly based on suggestion by @SamWilsn * Overlooked two external links, and removed them * Update EIPS/eip-4910.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Address requested changes by @SamWilsn - adopted suggestion by @SamWilsn to simplify headers and remove `Rationale` headers and remove the individual `Specification` headers. - found a way to remove requirements as headers using <a name="tag_name">...</a> * Minor function update to adding and removing a NFT listing * Updated the functions the wrong way * Addressing Editor comment 4/22/2022 - Fixing overlooked heading corrections per comment by @SamWilsn - Minor editing in the outline section to remove some headings to simplify the flow * Update EIPS/eip-4910.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update based on discussion with @SamWilsn on 5/17 - removed specific data structure structs and just generally talked about what things are required to be held in the smart contract - consequently removed 3 requirements - removed all optional [O] and conditional [CR] requirements - removed all but 1 should [D] requirements Decision of the call was also not to split the EIP into several EIPs since that does not reduce overall complexity, and makes creating reference implementations more difficult, hurting adoption. Net effect is to noticeably reduce the size of the specification. * Missed two unhyphenated ERC references -- fixed * Fixing EIP and HTML Validator errors save for reference implementation link * added separate rationale section for the spec * fixed link for EIP-20 * fixing links * Removed reference implementation and updated relevant section in the EIP accordingly * Update EIPS/eip-4910.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Document | Title |
---|---|
EIP-4910 | Royalty Bearing NFTs |