Update EIP-712: Fix `eth_signTypedData` definition (#5457)
* EIP-712: fix `eth_signTypedData` definition
The previous EIP text for `eth_signTypedData` seemed to describe the
existing "Ethereum signed message" flows, without any relation to typed
data. The new definition is consistent with what's actually implemented
by (e.g.) [the Ethers signer][1] and [the OpenZeppelin validator][2], as
well as with the start of the "Specification" section of this EIP.
[1]: https://github.com/ethers-io/ethers.js/blob/ce8f1e4015c0f27bf178238770b1325136e3351a/packages/hash/src.ts/typed-data.ts#L392-L398
[2]: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/1b27c13096d6e4389d62e7b0766a1db53fbb3f1b/contracts/utils/cryptography/ECDSA.sol#L216-L218
wchargin-branch: eip-712-eth-signtypeddata
wchargin-source: 9ad388c38b6b02da91d47e84e53284dadf4fe75b
* [eip-712-eth-signtypeddata: update syntax and verbiage slightly]
wchargin-branch: eip-712-eth-signtypeddata
wchargin-source: 49356fd9c5cce4159bff3395bb558ed5792f77f9
* Remove the correct stuff
* Fix another issue
* Never mind, this looks correct
---------
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
GitHub Diff